[v1 1/5] winejoystick.drv: Add functionality to disable joystick via registry

Bruno Jesus 00cpxxx at gmail.com
Sun Aug 28 01:28:54 CDT 2016


On Sun, Aug 28, 2016 at 3:18 AM, David Lawrie <david.dljunk at gmail.com> wrote:
> Adds device_disabled_registry, helper functions to shared joystick code

Hi, thanks for working on this. The problem with this series is that
you are introducing dead code in patches 1, 2 and 3. As the code is
not used anywhere until patch 5.
Patch 4 also adds dead code that is only used in patch 5.

IMO you should merge patches 1,2,3 into a single patch and also 4 and
5 into second patch. This will make the dead code will last a single
commit.

Best wishes,
Bruno



More information about the wine-devel mailing list