[resend v2 4/4] ddraw: Do refcounting only through wined3d_texture_{inc, dec}ref().

Sun Jan 3 12:44:07 CST 2016

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-01-03 um 18:06 schrieb Henri Verbeet:
>> -    wined3d_surface_incref(wined3d_surface);
>> +    wined3d_texture_incref(wined3d_texture);
>>      surface->wined3d_surface = wined3d_surface;
>> +    surface->wined3d_texture = wined3d_texture;
> The reference counting here is odd. You'd normally increment the
> reference count right before or after storing the pointer.
This goes back to one of my suggestions: The individual subresources already hold a reference to the texture. This decref removes the initial ref from the texture_create call. Doing it here avoids special treatment of subresource 0 in other places.

Though I guess a comment explaining this might be a reasonable thing to do.