[PATCH v3 6/6] shell32: Set output interfaces to NULL in FolderItems functions.

Alex Henrie alexhenrie24 at gmail.com
Thu Jul 7 00:39:39 CDT 2016


2016-07-06 11:39 GMT-06:00 Alex Henrie <alexhenrie24 at gmail.com>:
> 2016-07-06 1:13 GMT-06:00 Michael Stefaniuc <mstefani at redhat.com>:
>> On 07/06/2016 06:55 AM, Alex Henrie wrote:
>>> [...]
>>
>> This two if's look odd: one for ppid and then for !ppid.
>> Why don't you just unconditionally do the NULL assignment after the
>> check below?
>>
>>>      if (!ppid)
>>>          return E_INVALIDARG;
>
> Thanks for catching that. This is a mistake, according to the tests
> get_Parent should never return E_INVALIDARG.

The only difference between v3 and v4 of the patchset is the removal
of these two lines from FolderItemsImpl_get_Parent.

-Alex



More information about the wine-devel mailing list