[resend PATCH] msscript: Implement SetAdvise/GetAdvise

Nikolay Sivov bunglehead at gmail.com
Wed Jul 20 05:50:20 CDT 2016


On 20.07.2016 12:42, Jacek Caban wrote:
> Hi Nikolay,
> 
> On 19.07.2016 20:42, Nikolay Sivov wrote:
>> -static HRESULT WINAPI ViewObject_SetAdvise(IViewObjectEx *iface, DWORD aspects, DWORD advf, IAdviseSink *sink)
>> +static HRESULT WINAPI ViewObject_SetAdvise(IViewObjectEx *iface, DWORD aspects, DWORD flags, IAdviseSink *sink)
>>  {
>>      ScriptControl *This = impl_from_IViewObjectEx(iface);
>>  
>> -    FIXME("(%p)->(%d %d %p)\n", This, aspects, advf, sink);
>> +    TRACE("(%p)->(%d %#x %p)\n", This, aspects, flags, sink);
>>  
>> -    return E_NOTIMPL;
>> +    if (aspects != DVASPECT_CONTENT)
>> +        return DV_E_DVASPECT;
> 
> Since only DVASPECT_CONTENT is supported and it's also a default value,
> is there a reason to bother storing it in the object?

No, no reason. Thanks.

> 
> Thanks,
> Jacek
> 
> 




More information about the wine-devel mailing list