[v2 PATCH] ucrtbase: Implement _get_narrow_winmain_command_line/_get_wide_winmain_command_line

[Dmitry Timoshkov]

Piotr Caban <piotr.caban at gmail.com> wrote:

> > Once again:
> > Where did you get an idea of such an implementation? Is this copied from
> > some place or based on some other implementation? Why for instance simple
> > 'return GetCommandLineA()' is not enough as an initial implementation?
> 
> Probably I'm just stating obvious but the function skips executable name 
> from the command line. That's why returning what GetCommandLineA returns 
> is incorrect.

>From what documentation/description is that obvious? That's not a common
practice to send patches for not very obvious things without any tests.
Why this implementation treats specially tabs and spaces but not other
white space characters? Is that also obvious? How about the tests for
quotes/embedded quotes?

-- 
Dmitry.