[v2 4/7] msvcirt: Implement ostream::operator<< for floats
Piotr Caban
piotr.caban at gmail.com
Wed Jun 22 07:33:08 CDT 2016
On 06/22/16 14:23, Iván Matellanes wrote:
> On 22/06/16 12:25, Piotr Caban wrote:
>> On 06/22/16 11:53, Iván Matellanes wrote:
>>> + str_length += _scprintf(sprintf_fmt, prec, d); /* number
>>> representation */
>>> + if (str_length > 24) {
>>> + /* too long to output */
>>> + ostream_writepad(ostr, "", "");
>> Could you please add a test for it? Also a comment saying that this is
>> expected behavior would be useful.
> Thanks for the feedback.
> This is the expected behavior on Vista+. XP/2k3 crashes though, so I
> ended up removing the related tests. What's the proper way to handle this?
I think that you can just change the comment to make clear this is not
incomplete implementation.
Thanks,
Piotr
More information about the wine-devel
mailing list