[PATCH 5/7] d3drm: Fix device not assigning width and height after creation.

Henri Verbeet hverbeet at gmail.com
Wed Jun 29 09:31:09 CDT 2016


On 29 June 2016 at 16:13, Aaryaman Vasishta <jem456.vasishta at gmail.com> wrote:
> This is a helper function, so the caller would be handling the references.
> See CreateDeviceFromD3D in device.c.
>
That construction makes it harder to verify correctness, so in general
I'd recommend against that. Regardless, d3drm_device_destroy() takes
care of the device reference, but doesn't help for the IDirect3DRM
reference, since that's only released when device->ddraw is set.



More information about the wine-devel mailing list