shell32: Don't return argified string in FindExecutable
Alexandre Julliard
julliard at winehq.org
Mon Mar 21 08:35:43 CDT 2016
André Hentschel <nerv at dawncrow.de> writes:
> @@ -698,10 +698,15 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb,
>
> if (retval > 32)
> {
> - DWORD finishedLen;
> - SHELL_ArgifyW(lpResult, resultLen, command, xlpFile, pidl, args, &finishedLen);
> - if (finishedLen > resultLen)
> - ERR("Argify buffer not large enough.. truncated\n");
> + if (exec_only)
> + lstrcpynW(lpResult, command, resultLen);
> + else
> + {
> + DWORD finishedLen;
> + SHELL_ArgifyW(lpResult, resultLen, command, xlpFile, pidl, args, &finishedLen);
> + if (finishedLen > resultLen)
> + ERR("Argify buffer not large enough.. truncated\n");
> + }
That's not much of an improvement, and I don't see why it should be
limited to FindExecutable.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list