[5/5] strmbase: Shift source/destination rectangle when updating top or left property.
Andrew Eikum
aeikum at codeweavers.com
Mon Nov 21 10:10:04 CST 2016
On Sun, Nov 20, 2016 at 03:33:26PM +0900, Akihiro Sagawa wrote:
> @@ -212,7 +212,7 @@ HRESULT WINAPI BaseControlVideoImpl_put_SourceLeft(IBasicVideo *iface, LONG Sour
> hr = This->pFuncsTable->pfnGetSourceRect(This, &SourceRect);
> if (SUCCEEDED(hr))
> {
> - SourceRect.left = SourceLeft;
> + OffsetRect(&SourceRect, SourceLeft, 0);
> hr = BaseControlVideoImpl_CheckSourceRect(This, &SourceRect);
> }
> if (SUCCEEDED(hr))
These look wrong to me. The SourceLeft argument is an absolute
position, while OffsetRect takes an offset. Check my math, but I think
you want something like OffsetRect( SourceLeft - SourceRect.left ).
Andrew
More information about the wine-devel
mailing list