[PATCH] tools/winedump: Change duplicate flag.

[Alexandre Julliard]

Zebediah Figura <z.figura12 at gmail.com> writes:

> On 04/07/2017 02:29 PM, Alexandre Julliard wrote:
>> Zebediah Figura <z.figura12 at gmail.com> writes:
>> 
>>> On 04/07/2017 02:09 PM, Alexandre Julliard wrote:
>>>> Zebediah Figura <z.figura12 at gmail.com> writes:
>>>>
>>>>> diff --git a/tools/winedump/main.c b/tools/winedump/main.c
>>>>> index a4ebb43..5c683f6 100644
>>>>> --- a/tools/winedump/main.c
>>>>> +++ b/tools/winedump/main.c
>>>>> @@ -226,7 +226,7 @@ static const struct my_option option_table[] = {
>>>>>    {"-v",    SPEC, 0, do_verbose,  "-v              Show lots of detail while working (verbose)."},
>>>>>    {"dump",  DUMP, 0, do_dump,     "dump <file>     Dump the contents of 'file' (dll, exe, lib...)"},
>>>>>    {"-C",    DUMP, 0, do_symdmngl, "-C              Turn on symbol demangling"},
>>>>> -  {"-f",    DUMP, 0, do_dumphead, "-f              Dump file header information"},
>>>>> +  {"-F",    DUMP, 0, do_dumphead, "-F              Dump file header information"},
>>>>
>>>> Not a big deal, but is there a reason for changing this?
>>>>
>>>
>>> The -f flag is assigned to two different options, yielding this one
>>> unreachable.
>> 
>> No, it works fine. The options are specific to each mode.
>
> If "dump" isn't explicitly specified, as "winedump file.exe -f", it
> fails with "Only one file can be treated at once". If this is intended,
> then perhaps "winedump file.exe" without any extra arguments should also
> fail?

That wouldn't be an improvement. What is intended is that the "dump"
keyword is optional, since that's what we want 99% of the time. So the
dump options should work the same way with or without an explicit "dump"
keyword. If that's not the case, the option parser has to be fixed.

-- 
Alexandre Julliard
julliard at winehq.org