[PATCH 04/18] comctl32: Extend TaskDialog, add simple callback and tests

Fabian Maurer dark.shadow4 at web.de
Sun Feb 26 13:17:53 CST 2017


> > For that please use msg.h from comctl32/tests.
> 
> I'd love to, but I'm not sure how this would work.
> After all, the message lists for the taskdialogs use a different struct with
> additional values, like the return value it should give, and a sync value.
> I agree that the current way isn't too elegant, how would you go about
> that?

Thought about it a while longer, but it's not easy.
The current code uses
> while (expected->message && actual->message)
to process the messages.
However, the problem is that TDN_CREATED is zero, terminating the loop way to 
early. That's why I added TDN_NO_MORE_MESSAGES in the first place. If I should 
use msg.h from comctl32, then I need to rewrite a bunch of its code.

How do we want to handle it?

Regards,
Fabian Maurer



More information about the wine-devel mailing list