[PATCH] user.exe16: Add missing SELECTOROF in WM_DDE_EXECUTE.

[Zebediah Figura]

On 01/05/2017 05:23 AM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12 at gmail.com> writes:
> 
>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>> ---
>>  dlls/user.exe16/message.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/dlls/user.exe16/message.c b/dlls/user.exe16/message.c
>> index 7bcc8e2..383d746 100644
>> --- a/dlls/user.exe16/message.c
>> +++ b/dlls/user.exe16/message.c
>> @@ -900,7 +900,7 @@ LRESULT WINPROC_CallProc16To32A( winproc_callback_t callback, HWND16 hwnd, UINT1
>>          }
>>          break; /* FIXME don't know how to free allocated memory (handle) !! */
>>      case WM_DDE_EXECUTE:
>> -        lParam = convert_handle_16_to_32( lParam, GMEM_DDESHARE );
>> +        lParam = convert_handle_16_to_32( SELECTOROF(lParam), GMEM_DDESHARE );
> 
> This won't work without fixing the opposite mapping. Do you have a
> reference for this? What application is this for?
> 

Sorry, I'm a little new to Wine development.

The application is The Magic School Bus Explores The Solar System [1],
an old educational game. I was trying to fix a bug [2] in which the
Progman DDE interface, besides being unimplemented, was being passed
garbage memory. The program itself was passing values like 14660000 to
lParam.

[1] https://appdb.winehq.org/objectManager.php?sClass=application&iId=16858
[2] https://bugs.winehq.org/show_bug.cgi?id=42023