[PATCH 2/2] comctl32/propsheet: Implement PSPCB_ADDREF/PSPCB_RELEASE notifications

[Dmitry Timoshkov]

"Erich E. Hoover" <erich.e.hoover at wine-staging.com> wrote:

> > I just pointed out to an ill-behaving practices you're using, and asked
> > to either stop doing such bad things, or give a credit to the source.
> > Since the original wine-staging patch is pretty trivial it's not a big
> > problem in this case, but taking into account your practice to "borrow"
> > wine-staging work it may become a real problem at some point, at least
> > as a distorted image of the company you are working for.
> >
> > P.S.
> > Thanks for confirming that the wine-staging patch was the starting point
> > of your work.
> 
> At the risk of exploding this further, it looks like Nikolay put
> together a really nice patch that has undergone far more testing than
> what's in staging.  As we don't have a requirement on saying that a
> patch is "inspired" by someone else's work I don't see any reason to
> be so aggressive when this patch is clearly unique.  So, I'm sorry
> your feeling left out in terms of credit, but I don't think that
> attacking Nikolay is a very appropriate response.

While there is no any requirement to give a credit, there are things like
respect to someone who did the dirty work and spent his own personal time
by investigating an issue, and prepared an inital (if not even a perfect)
working solution. I have to add that it took quite a bit of time and an
effort to track down what exactly was wrong with Process Hacker, and why
it crashes once in a while. That said, what Nikolay is doing completely
kills any motivation to do any investigation work on Wine bugs. So please
don't be surprised and keep moaning on every wineconf that not that much
well qualified people are interested to even look on Wine bugs, not speaking
about having a peek in attempting to fix something, give full credit for that
to people like Nikolay who instead of doing their own hard work by investigating
bugs, try to steal a low hanging fruit by "borrowing" the work done by somebody
else.

-- 
Dmitry.