[2/2] include: Introduce a with_context macro and use it to simplify vcomp tests. [RFC]

Sebastian Lackner sebastian at fds-team.de
Tue Mar 14 10:27:05 CDT 2017


On 14.03.2017 11:45, Henri Verbeet wrote:
> On 14 March 2017 at 01:56, Bruno Jesus <00cpxxx at gmail.com> wrote:
>> Hi, Sebastian. I like this idea, it would be specially useful for
>> table struct tests (eg ws2_32) and functions that are called more than
>> once for different tests (eg rsaenh). Each maintainer/helper could
>> slowly update the tests as they think it fits and new tests could
>> start benefiting from it. I hope more people join this conversation as
>> it clearly took a long time to produce the patch and letting it drop
>> from the list without talk would not be nice ;-)
>>
> Well, for what it's worth, I'd welcome the functionality, although
> personally I'd be tempted to go for
> winetest_push_context()/winetest_pop_context() and avoid the extra
> indentation.

Thanks for the feedback. I will send a modified version without the
macro if you think it is preferred.

> 
> On 7 March 2017 at 18:29, Sebastian Lackner <sebastian at fds-team.de> wrote:
>> It can also be combined with a loop like:
>>
>> for (i = 0; i < 100; i++)
>> with_context("i = %d", i)
>> {
>>     ...
>> }
>>
> But e.g. "break" would be problematic inside such a loop, right?
> 

Yes, break would be problematic, but continue for example would work
fine.

Best regards,
Sebastian




More information about the wine-devel mailing list