[v2 2/2] msvcrt: Add stub for Concurrency::Free

[Gijs Vermeulen]

Hi,

Thank you for the review.
I have sent an updated version of both patches with your suggestions
applied.

Sincerely,
Gijs

<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2017-03-17 15:44 GMT+01:00 Piotr Caban <piotr.caban at gmail.com>:

> Hi,
>
> Please also move this code to heap.c and rename the function and argument
> (e.g. to mem).
>
> On 03/16/17 23:12, Gijs Vermeulen wrote:
>
>> +/* ?Free at Concurrency@@YAXPAX at Z */
>> +/* ?Free at Concurrency@@YAXPEAX at Z */
>> +void __cdecl Free(void * _PAllocation)
>> +{
>> +    FIXME("(%p) stub\n", _PAllocation);
>>
> Even so it's a semi-stub it's better to free the memory here. Applications
> have no guarantee that memory block will be cached anyway.
>
> Thanks,
> Piotr
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20170318/2ed421f2/attachment.html>