wined3d: A grammar fix in a comment.
Francois Gouget
fgouget at free.fr
Tue Mar 21 02:55:11 CDT 2017
On Mon, 13 Mar 2017, Henri Verbeet wrote:
> On 12 March 2017 at 20:47, Francois Gouget <fgouget at free.fr> wrote:
> > @@ -3645,8 +3645,8 @@ static void wined3d_adapter_init_limits(struct wined3d_gl_info *gl_info)
> > gl_info->gl_ops.gl.p_glGetIntegerv(GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS, &gl_max);
> > gl_info->limits.compute_samplers = gl_max;
> > TRACE("Max compute samplers: %u.\n", gl_info->limits.compute_samplers);
> > - /* A majority of OpenGL implementations allow to statically partition
> > - * the set of texture bindings into six separate sets. */
> > + /* A majority of OpenGL implementations allow applications to statically
> > + * partition the set of texture bindings into six separate sets. */
> I think that changes the meaning somewhat.
Ok. The problem is that the 'allow_to' function takes 3 parameters:
a allow b to c
Where we have:
a = "A majority of OpenGL implementations"
c = "statically partition the set of texture bindings into six separate sets."
Being a security API, all parameters are mandatory but here we are
missing b so we don't know who gets this special permission. Kind of bad
for a security API you'll agree, and the reason why I tried to figure
out what this parameter should be set to.
Maybe a better idea would be to switch to an API made for announcing
capabilities: the 'make_it_possible_to' API. Now I think of it, it would
probably be a better fit, should be a drop in replacement, and has lower
security implications too. So if there is no objection I'll submit
something like this:
A majority of OpenGL implementations make it possible to partition
the set of texture bindings into six separate sets.
--
Francois Gouget <fgouget at free.fr> http://fgouget.free.fr/
Stolen from an Internet user:
"f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"
More information about the wine-devel
mailing list