[PATCH 2/4] testbot: Add a note regarding the detection of new errors.
Francois Gouget
fgouget at codeweavers.com
Sun Aug 26 03:17:47 CDT 2018
The detection of new errors may be based on a WineTest report which is
not up-to-date. However this should not be a real issue in practice.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This is not a new issue.
testbot/bin/WineSendLog.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index f3b56d8c9..b0efa8c33 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -266,6 +266,12 @@ EOF
# Build a job summary with only the new errors
#
+ # Note that this may be a bit inaccurate right after a Wine commit if this
+ # job's patch got compiled on top of the new Wine before all the reference
+ # WineTest results were updated. This is made more likely by the job
+ # priorities: high for Wine updates, and low for WineTest runs.
+ # However in practice this would only be an issue if the patch reintroduced
+ # an error that just disappeared in the latest Wine which is highly unlikely.
my @Messages;
foreach my $Key (@SortedKeys)
{
--
2.18.0
More information about the wine-devel
mailing list