[PATCH] schannel/tests: Relax GetInfo return value test
Dmitry Timoshkov
dmitry at baikal.ru
Sun Feb 18 22:40:24 CST 2018
Alex Henrie <alexhenrie24 at gmail.com> wrote:
> status = pTables->GetInfo(&PackageInfo);
> - ok(status == STATUS_SUCCESS ||
> + ok(SUCCEEDED(status) ||
> status == SEC_E_UNSUPPORTED_FUNCTION, /* win2k3 */
> "status: 0x%x\n", status);
>
> - if (status == STATUS_SUCCESS)
> + if (SUCCEEDED(status))
> {
> ok(PackageInfo.fCapabilities == LSA_BASE_CAPS ||
> PackageInfo.fCapabilities == (LSA_BASE_CAPS|SECPKG_FLAG_APPCONTAINER_PASSTHROUGH),
SUCCEEDED() is supposed to be used for HRESULT codes not for NTSTATUS ones.
But in this particular case this mess could be attributed directly to MS,
as SSP/AP interfaces are declared to return NTSTATUS, but in reality they
do return HRESULT (or rather SECURITY_STATUS) values.
--
Dmitry.
More information about the wine-devel
mailing list