[PATCH 3/6] msxml3/tests: Add missing return value checks to domdoc tests (Coverity)
Alex Henrie
alexhenrie24 at gmail.com
Mon Jan 8 02:18:56 CST 2018
2018-01-07 23:38 GMT-07:00 Nikolay Sivov <nsivov at codeweavers.com>:
>>
>> /* compare */
>> - ok(!lstrcmpW(data, get_data), "%d: got wrong data %s, expected
>> %s\n", *type, wine_dbgstr_w(get_data),
>> - wine_dbgstr_w(data));
>> + ok(get_data && !lstrcmpW(data, get_data), "%d: got wrong data %s,
>> expected %s\n",
>> + *type, wine_dbgstr_w(get_data), wine_dbgstr_w(data));
>> SysFreeString(get_data);
>> IXMLDOMNode_Release(node);
>
> Do we have actual crashes because of that?
Interesting, Coverity thinks that lstrcmpW doesn't check for null
pointers, but Wine's implementation of it does. I'll have to do more
testing to see who's correct.
-Alex
More information about the wine-devel
mailing list