[PATCH] testbot: Standardize on push to append to an array.

Francois Gouget fgouget at codeweavers.com
Thu Mar 1 18:22:51 CST 2018


Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineSendLog.pl      | 4 ++--
 testbot/lib/ObjectModel/Item.pm | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 62024d97e..ec9a587b5 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -297,7 +297,7 @@ EOF
       }
       else
       {
-        $FailureKeys[scalar @FailureKeys] = $Key;
+        push @FailureKeys, $Key;
       }
     }
     elsif (open ERRFILE, "<$TaskDir/err")
@@ -317,7 +317,7 @@ EOF
       }
       else
       {
-        $FailureKeys[scalar @FailureKeys] = $Key;
+        push @FailureKeys, $Key;
       }
     }
   }
diff --git a/testbot/lib/ObjectModel/Item.pm b/testbot/lib/ObjectModel/Item.pm
index 629613081..e1385b8c7 100644
--- a/testbot/lib/ObjectModel/Item.pm
+++ b/testbot/lib/ObjectModel/Item.pm
@@ -320,8 +320,8 @@ sub GetMasterKey($)
     {
       foreach my $ColName (@{$PropertyDescriptor->GetColNames()})
       {
-        @MasterColNames[scalar @MasterColNames] = $ColNamePrefix . $ColName;
-        @MasterColValues[scalar @MasterColValues] = $self->GetColValue($ColName);
+        push @MasterColNames, $ColNamePrefix . $ColName;
+        push @MasterColValues, $self->GetColValue($ColName);
       }
     }
   }
-- 
2.16.1



More information about the wine-devel mailing list