[PATCH v2 2/2] advapi32: Don't read the key name if the root key handle is invalid

Alexandre Julliard julliard at winehq.org
Thu Nov 8 12:57:32 CST 2018


Alex Henrie <alexhenrie24 at gmail.com> writes:

> On Thu, Nov 8, 2018 at 9:49 AM Alexandre Julliard <julliard at winehq.org> wrote:
>> Is there an app that depends on this? Adding a lot of error checking
>> only to satisfy artificial test cases is usually not desirable.
>
> Considering how commonly this function is used and the fact that it
> has a Coverity warning, I think it's very likely that at least one
> application depends on at least checking the name parameter.

On the contrary, because the function is commonly used, if there was
something wrong with it we'd most likely have heard about it by now.
Also AFAICT Coverity is mistaken, there's nothing wrong here.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list