[PATCH 2/4] wined3d: Add fast-path for texture download blit.

Andrew Wesie awesie at gmail.com
Wed Oct 3 11:02:54 CDT 2018


On Wed, Oct 3, 2018 at 10:16 AM Henri Verbeet <hverbeet at gmail.com> wrote:

> Moving these down means uploads/downloads will potentially be used for
> colour-key and alpha-test blits, which seems wrong. Was that change
> intentional?
>

The problem I was trying to solve is that blit_op
= WINED3D_BLIT_OP_RAW_BLIT still needs to happen if we cannot do the
download for some reason (e.g. texture sizes don't match). I agree that the
change is not obviously correct.

How about moving the upload / download to after the conditionals and
verifying blit_op == WINED3D_BLIT_OP_RAW_BLIT?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20181003/1ede3433/attachment.html>


More information about the wine-devel mailing list