[PATCH] qcap: Fix a COM reference leak in the audiorecord test.
Zebediah Figura
z.figura12 at gmail.com
Mon Apr 22 15:36:14 CDT 2019
On 4/22/19 1:06 PM, Damjan Jovanovic wrote:
>
>
> On Mon, Apr 22, 2019 at 7:51 PM Zebediah Figura <z.figura12 at gmail.com
> <mailto:z.figura12 at gmail.com>> wrote:
>
> On 04/22/2019 02:38 AM, Damjan Jovanovic wrote:
> > Signed-off-by: Damjan Jovanovic <damjan.jov at gmail.com
> <mailto:damjan.jov at gmail.com>>
> > ---
> > dlls/qcap/tests/audiorecord.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> >
> >
> >
>
> Thanks for finding the leak. "filter" can never be NULL at that point,
> and we also want to test that we really are releasing the last
> reference. I've sent an updated patch that addresses these.
>
>
> Pleasure.
> It can be NULL, if IMoniker_BindToObject() fails.
>
>
>
IMoniker::BindToObject() shouldn't fail; that's checked above.
More information about the wine-devel
mailing list