[PATCH 2/5] msvcrt: Refactor failure code for create_locinfo.

Piotr Caban piotr.caban at gmail.com
Tue Dec 3 06:18:17 CST 2019


Hi Jeff,

On 12/2/19 6:52 PM, Jeff Smith wrote:
> -    if(!locinfo->lconv) {
> -        free_locinfo(locinfo);
> -        return NULL;
> -    }
> +    if(!locinfo->lconv)
> +        goto failed;
I'm not sure if it's an improvement. I think I would prefer the code to 
stay as it is.

Thanks,
Piotr



More information about the wine-devel mailing list