[PATCH] kerberos: Fix compilation on systems where SONAME_LIBKRB5 is not defined.

[Dmitry Timoshkov]

Alexandre Julliard <julliard at winehq.org> wrote:

> Dmitry Timoshkov <dmitry at baikal.ru> writes:
> 
> > Alexandre Julliard <julliard at winehq.org> wrote:
> >
> >> > Hans Leidekker <hans at codeweavers.com> wrote:
> >> >
> >> >> On Tue, 2019-07-02 at 18:14 +0800, Dmitry Timoshkov wrote:
> >> >> > Sounds like a broken install. To fix this I think it would be better to improve
> >> >> > > our configure check than to add more (nested) ifdefs.
> >> >> > 
> >> >> > I believe that the added ifdefs are actually necessary, and they logically
> >> >> > separate libkrb5 functionality from libgssapi one. Without libkrb5 the only
> >> >> > things that won't be supported are custom credentials and the ticket cache,
> >> >> > everything else works just fine.
> >> >> > 
> >> >> > > AcquireCredentialsHandle won't be very useful without these krb5 functions.
> >> >> > 
> >> >> > It works just fine with cached system credentials.
> >> >> 
> >> >> gssapi itself depends on krb5, so there's no reason to build with partial support.
> >> >
> >> > Apparently there are configurations where that's not the case, and supporting them
> >> > isn't that hard as the patch shows.
> >> 
> >> Have you verified that the library is truly missing, or is it only the
> >> .so symlink from the dev package?
> >
> > I've relayed your question, and got the following answer: "only the dev
> > package with the .so symlink was missing".
> 
> OK, thanks. It seems that failing at configure time with a warning is
> more appropriate then.

I agree, taking into account addtional information.

-- 
Dmitry.