[PATCH] msvcp90: Fix vtable alignment on macOS.
Alexandre Julliard
julliard at winehq.org
Fri Mar 15 03:49:50 CDT 2019
Austin English <austinenglish at gmail.com> writes:
> On Thu, Mar 7, 2019, 09:48 Alexandre Julliard <julliard at winehq.org> wrote:
>
> Ken Thomases <ken at codeweavers.com> writes:
>
> > On Mar 6, 2019, at 9:28 PM, Chip Davis <cdavis at codeweavers.com> wrote:
> >>
> >> March 6, 2019 7:01 PM, "Ken Thomases" <ken at codeweavers.com> wrote:
> >>
> >>> On macOS, the .align <n> directive aligns to 2^n, not just n.
> >>
> >> I wonder if we should explicitly use '.balign 8', since that always means "align to 8 bytes." Unless, of course, there are platforms that don't support it.
> >
> > This is a general issue that winebuild also explicitly contends with,
> > and it isn't using .balign (nor .p2align). See
> > tools/winebuild/utils.c:get_alignment(). So, I assume .balign isn't
> > an acceptable solution. I'd be happy to be told otherwise, though.
>
> It's not supported on Solaris, which was the reason for the winebuild
> code. I'm not sure if anybody still cares about Solaris nowadays...
>
> --
> Alexandre Julliard
> julliard at winehq.org
>
> Does this also mean we can kill backticks in shell scripts? ;)
There's no reason to change existing scripts, but we can stop using
backticks in new code and see if anybody complains.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list