[PATCH] hnetcfg: Initialize INetFwRules::get__NewEnum out parameter.

Gijs Vermeulen gijsvrm at gmail.com
Tue Mar 26 11:04:44 CDT 2019


Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46906
Signed-off-by: Gijs Vermeulen <gijsvrm at gmail.com>
---
 dlls/hnetcfg/policy.c       | 4 ++++
 dlls/hnetcfg/tests/policy.c | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/dlls/hnetcfg/policy.c b/dlls/hnetcfg/policy.c
index 53f39ae46f..26b7cc169a 100644
--- a/dlls/hnetcfg/policy.c
+++ b/dlls/hnetcfg/policy.c
@@ -238,6 +238,10 @@ static HRESULT WINAPI netfw_rules_get__NewEnum(
     fw_rules *This = impl_from_INetFwRules( iface );
 
     FIXME("%p, %p\n", This, newEnum);
+
+    if (!newEnum) return E_POINTER;
+    *newEnum = NULL;
+
     return E_NOTIMPL;
 }
 
diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c
index 3fa8348b6e..8701455841 100644
--- a/dlls/hnetcfg/tests/policy.c
+++ b/dlls/hnetcfg/tests/policy.c
@@ -60,6 +60,9 @@ static void test_policy2_rules(INetFwPolicy2 *policy2)
         INetFwServiceRestriction_Release(restriction);
     }
 
+    hr = INetFwRules_get__NewEnum(rules, NULL);
+    ok(hr == E_POINTER, "got %08x\n", hr);
+
     INetFwRules_Release(rules);
     INetFwRules_Release(rules2);
 }
-- 
2.21.0




More information about the wine-devel mailing list