[PATCH v2 4/4] shell32/autocomplete: Use LBS_NODATA for the dropdown listbox
Gabriel Ivăncescu
gabrielopcode at gmail.com
Thu Mar 28 07:24:32 CDT 2019
This eliminates the overhead of populating the listbox completely and
simplifies the code.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
dlls/shell32/autocomplete.c | 63 ++++++++++++++-----------------------
1 file changed, 23 insertions(+), 40 deletions(-)
diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c
index 1a88a1d..0acdaa6 100644
--- a/dlls/shell32/autocomplete.c
+++ b/dlls/shell32/autocomplete.c
@@ -398,16 +398,11 @@ static BOOL select_item_with_return_key(IAutoCompleteImpl *ac, HWND hwnd)
INT sel = SendMessageW(hwndListBox, LB_GETCURSEL, 0, 0);
if (sel >= 0)
{
- UINT len = SendMessageW(hwndListBox, LB_GETTEXTLEN, sel, 0);
- if ((text = heap_alloc((len + 1) * sizeof(WCHAR))))
- {
- len = SendMessageW(hwndListBox, LB_GETTEXT, sel, (LPARAM)text);
- set_text_and_selection(ac, hwnd, text, 0, len);
- hide_listbox(ac, hwndListBox, TRUE);
- ac->no_fwd_char = '\r'; /* RETURN char */
- heap_free(text);
- return TRUE;
- }
+ text = ac->listbox_strs[sel];
+ set_text_and_selection(ac, hwnd, text, 0, strlenW(text));
+ hide_listbox(ac, hwndListBox, TRUE);
+ ac->no_fwd_char = '\r'; /* RETURN char */
+ return TRUE;
}
}
hide_listbox(ac, hwndListBox, TRUE);
@@ -416,6 +411,9 @@ static BOOL select_item_with_return_key(IAutoCompleteImpl *ac, HWND hwnd)
static LRESULT change_selection(IAutoCompleteImpl *ac, HWND hwnd, UINT key)
{
+ WCHAR *msg;
+ UINT len;
+
INT count = SendMessageW(ac->hwndListBox, LB_GETCOUNT, 0, 0);
INT sel = SendMessageW(ac->hwndListBox, LB_GETCURSEL, 0, 0);
if (key == VK_PRIOR || key == VK_NEXT)
@@ -456,21 +454,11 @@ static LRESULT change_selection(IAutoCompleteImpl *ac, HWND hwnd, UINT key)
sel = ((sel + 1) >= count) ? -1 : sel + 1;
SendMessageW(ac->hwndListBox, LB_SETCURSEL, sel, 0);
- if (sel >= 0)
- {
- WCHAR *msg;
- UINT len = SendMessageW(ac->hwndListBox, LB_GETTEXTLEN, sel, 0);
- if (!(msg = heap_alloc((len + 1) * sizeof(WCHAR))))
- return 0;
- len = SendMessageW(ac->hwndListBox, LB_GETTEXT, sel, (LPARAM)msg);
- set_text_and_selection(ac, hwnd, msg, len, len);
- heap_free(msg);
- }
- else
- {
- UINT len = strlenW(ac->txtbackup);
- set_text_and_selection(ac, hwnd, ac->txtbackup, len, len);
- }
+
+ msg = (sel >= 0) ? ac->listbox_strs[sel] : ac->txtbackup;
+ len = strlenW(msg);
+ set_text_and_selection(ac, hwnd, msg, len, len);
+
return 0;
}
@@ -596,9 +584,7 @@ static BOOL display_matching_strs(IAutoCompleteImpl *ac, WCHAR *text, UINT len,
SendMessageW(ac->hwndListBox, LB_RESETCONTENT, 0, 0);
ac->listbox_strs = str + start;
- SendMessageW(ac->hwndListBox, LB_INITSTORAGE, end - start, 0);
- for (; start < end; start++)
- SendMessageW(ac->hwndListBox, LB_INSERTSTRING, -1, (LPARAM)str[start]);
+ SendMessageW(ac->hwndListBox, LB_SETCOUNT, end - start, 0);
show_listbox(ac);
SendMessageW(ac->hwndListBox, WM_SETREDRAW, TRUE, 0);
@@ -859,7 +845,7 @@ static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam,
{
IAutoCompleteImpl *This = (IAutoCompleteImpl *)GetWindowLongPtrW(hwnd, GWLP_USERDATA);
WCHAR *msg;
- int sel, len;
+ INT sel;
switch (uMsg) {
case WM_MOUSEMOVE:
@@ -870,13 +856,9 @@ static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam,
sel = SendMessageW(hwnd, LB_GETCURSEL, 0, 0);
if (sel < 0)
return 0;
- len = SendMessageW(hwnd, LB_GETTEXTLEN, sel, 0);
- if (!(msg = heap_alloc((len + 1) * sizeof(WCHAR))))
- return 0;
- len = SendMessageW(hwnd, LB_GETTEXT, sel, (LPARAM)msg);
- set_text_and_selection(This, This->hwndEdit, msg, 0, len);
+ msg = This->listbox_strs[sel];
+ set_text_and_selection(This, This->hwndEdit, msg, 0, strlenW(msg));
hide_listbox(This, hwnd, TRUE);
- heap_free(msg);
return 0;
}
return CallWindowProcW(This->wpOrigLBoxProc, hwnd, uMsg, wParam, lParam);
@@ -912,7 +894,7 @@ static void create_listbox(IAutoCompleteImpl *This)
/* FIXME : The listbox should be resizable with the mouse. WS_THICKFRAME looks ugly */
This->hwndListBox = CreateWindowExW(0, WC_LISTBOXW, NULL,
- WS_CHILD | WS_VISIBLE | WS_VSCROLL | LBS_HASSTRINGS | LBS_OWNERDRAWFIXED | LBS_NOINTEGRALHEIGHT,
+ WS_CHILD | WS_VISIBLE | WS_VSCROLL | LBS_NODATA | LBS_OWNERDRAWFIXED | LBS_NOINTEGRALHEIGHT,
0, 0, 0, 0, This->hwndListBoxOwner, NULL, shell32_hInstance, NULL);
if (This->hwndListBox) {
@@ -1255,11 +1237,12 @@ static HRESULT WINAPI IAutoCompleteDropDown_fnGetDropDownStatus(
sel = SendMessageW(This->hwndListBox, LB_GETCURSEL, 0, 0);
if (sel >= 0)
{
- DWORD len;
+ WCHAR *str = This->listbox_strs[sel];
+ size_t size = (strlenW(str) + 1) * sizeof(*str);
- len = SendMessageW(This->hwndListBox, LB_GETTEXTLEN, sel, 0);
- *ppwszString = CoTaskMemAlloc((len+1)*sizeof(WCHAR));
- SendMessageW(This->hwndListBox, LB_GETTEXT, sel, (LPARAM)*ppwszString);
+ if (!(*ppwszString = CoTaskMemAlloc(size)))
+ return E_OUTOFMEMORY;
+ memcpy(*ppwszString, str, size);
}
else
*ppwszString = NULL;
--
2.20.1
More information about the wine-devel
mailing list