[PATCH 1/2] kernel32: Add sxs tests
Fabian Maurer
dark.shadow4 at web.de
Fri May 31 08:12:49 CDT 2019
Hello Alexandre,
> These should be reported as errors, not just skipped.
Right, I'll fix that.
> Please use the appropriate constant instead of 14001. Also, why does it
> fail?
Will do. It fails because windows XP doesn't support manifests outside of PE
files. I could add a comment next to the check for broken().
> > + FreeLibrary(info->module);
> > + FreeLibrary(info->module); /* Make sure it's freed in any case */
>
> Why do you need this?
On current wine, one dll gets loaded twice while the other isn't loaded at
all. For the tests not to fail, I need to free the module twice, to make 100%
sure it's unloaded before trying to delete it.
At least that was the most sensible approach that came to my mind.
Regards,
Fabian Maurer
More information about the wine-devel
mailing list