[PATCH 5/7] widl: Cast freed pointers to void* to fix discarded-array-qualifiers warning.
Zebediah Figura
z.figura12 at gmail.com
Wed Nov 13 09:49:17 CST 2019
On 11/13/19 7:51 AM, Rémi Bernon wrote:
> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> ---
> tools/widl/typegen.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
This is for bug 39692, right?
For what it's worth, MIDL doesn't do this. Not that that necessarily
means we shouldn't either; just making sure it's known.
> diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
> index f37c7b0d675..9b8aa1a3229 100644
> --- a/tools/widl/typegen.c
> +++ b/tools/widl/typegen.c
> @@ -4286,7 +4286,7 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const
> {
> print_file(file, indent, "if (%s%s)\n", local_var_prefix, var->name);
> indent++;
> - print_file(file, indent, "__frame->_StubMsg.pfnFree(%s%s);\n", local_var_prefix, var->name);
> + print_file(file, indent, "__frame->_StubMsg.pfnFree((void*)%s%s);\n", local_var_prefix, var->name);
> }
> }
> else
> @@ -4361,7 +4361,7 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const
> print_phase_function(file, indent, array_type, local_var_prefix, phase, var, start_offset);
> print_file(file, indent, "if (%s%s)\n", local_var_prefix, var->name);
> indent++;
> - print_file(file, indent, "__frame->_StubMsg.pfnFree(%s%s);\n", local_var_prefix, var->name);
> + print_file(file, indent, "__frame->_StubMsg.pfnFree((void*)%s%s);\n", local_var_prefix, var->name);
> break;
> }
> }
> @@ -4463,7 +4463,7 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const
> {
> print_file(file, indent, "if (%s%s)\n", local_var_prefix, var->name);
> indent++;
> - print_file(file, indent, "__frame->_StubMsg.pfnFree(%s%s);\n", local_var_prefix, var->name);
> + print_file(file, indent, "__frame->_StubMsg.pfnFree((void*)%s%s);\n", local_var_prefix, var->name);
> indent--;
> }
> break;
>
More information about the wine-devel
mailing list