[PATCH v2] http.sys: Initialize address structure before use. (Coverity)

Zebediah Figura z.figura12 at gmail.com
Fri Sep 6 08:48:12 CDT 2019


On 9/5/19 10:36 PM, Alistair Leslie-Hughes wrote:
> CID 1453504
> 
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> ---
>  dlls/http.sys/http.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c
> index b5d5a219dc..02320d487f 100644
> --- a/dlls/http.sys/http.c
> +++ b/dlls/http.sys/http.c
> @@ -1053,6 +1053,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp)
>  
>      TRACE("host %s, context %s.\n", debugstr_a(params->url), wine_dbgstr_longlong(params->context));
>  
> +    memset( &addr, 0, sizeof(addr) );
>      if (!strncmp(params->url, "https://", 8))
>      {
>          FIXME("HTTPS is not implemented.\n");
> 

Given that the the thing Coverity is complaining about is sin_zero, is
this really a salient warning to fix?



More information about the wine-devel mailing list