[PATCH] wined3d: Allow loading buffers mapped through system memory.

Paul Gofman gofmanp at gmail.com
Mon Sep 23 08:28:43 CDT 2019


That probably means that some GL drivers allow drawing from mapped
buffers. My Nvidia does not, this is from the test of the concern:

0009:err:d3d:wined3d_debug_callback 0x1ce7a0: "GL_INVALID_OPERATION
error generated. Buffer is mapped.".

Do you think it is ok then to just drop the unstable test (that second
attempt draws)? I am afraid it might be too fragile regardless, the
failure that I initially expect here is already relying on hitting the
direct map case in wined3d buffer.c, which is likely to change sooner or
later.

On 9/23/19 15:50, Henri Verbeet wrote:
> On Fri, 20 Sep 2019 at 21:06, Paul Gofman <gofmanp at gmail.com> wrote:
>> +        todo_wine_if(tests[i].todo)
>> +        ok(color_match(color, 0x00ff0000, 1), "Got unexpected color 0x%08x, test %u.\n", color, i);
>> +
> This fails here:
>
>     visual.c:26243: Test succeeded inside todo block: Got unexpected
> color 0x00ff0000, test 0.






More information about the wine-devel mailing list