[PATCH] riched20: Properly initialize variable (valgrind)

Fabian Maurer dark.shadow4 at web.de
Wed Feb 19 09:07:25 CST 2020


Hello Nicolay,

thanks for your comment.

> While this will silence the warning, which case is the problem? It could
> indicate actual issue somewhere else in the code, when mask is set for
> uninitialized field, or field is used with mask unset.

The problem is that szFacename is an array inside the struct, and the struct
gets compared against another struct. Since the array is never 100% full, that
means we compare all the garbage in the array as well. I adjusted the patch to
make it more clear.

Regards,
Fabian Maurer





More information about the wine-devel mailing list