[PATCH] user32/msgbox: Implement copying contents to clipboard

Vadim Zeitlin vz-wine at zeitlins.org
Wed Jan 22 17:40:54 CST 2020


On Wed, 22 Jan 2020 20:37:04 +0100 Fabian Maurer <dark.shadow4 at web.de> wrote:

FM> FWIW, that's bug https://bugs.winehq.org/show_bug.cgi?id=17205

 Sorry for somehow missing this and thanks for pointing this out!

FM> A staging patchset is available at https://github.com/wine-staging/wine-staging/tree/master/patches/user32-msgbox-Support-WM_COPY-mesg

 Looking at this patch, I see that it's clearly better than mine in some
aspects (e.g. it includes tests) but OTOH I'm not sure if using a hook for
this is really a good idea, and it seems to have resulted in the problems
as discussed at the bug above. There is also another small but annoying
difference: the other patch doesn't take Ctrl-Ins into account, even though
it works in the same way as Ctrl-C under native MSW.

 So what should/can I do now? Would it be worth to update my patch to
combine it with the tests from the patch by Alistair Leslie-Hughes? Also,
mostly for the future, should I have submitted this patch to Wine staging
instead of here?

 Thanks in advance,
VZ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200123/49a98916/attachment.sig>


More information about the wine-devel mailing list