[PATCH] ws2_32: Drop dependencies on system getprotoby(name|number) functions

Gabriel Ivăncescu gabrielopcode at gmail.com
Mon Jul 13 08:33:37 CDT 2020


On 13/07/2020 07:51, Alex Henrie wrote:
> On Sun, Jul 12, 2020 at 10:12 PM Zebediah Figura <z.figura12 at gmail.com> wrote:
>>
>> I guess this is a matter of opinion, but I don't think the table is more
>> readable in this form.
> 
> I figured the empty entries were worth making getprotobynumber run in
> constant time. But the table is so small that maybe that doesn't
> really matter. I'd love to hear some more opinions.
> 
> -Alex
> 

You could also use a binary search, since it's sorted (with a comment 
before it to keep it sorted) which is plenty fast enough, and still 
keeps the table more readable. Obviously in a separate patch, though.



More information about the wine-devel mailing list