[PATCH 1/2] dwrite/tests: Add some tests for Segoe UI font family. (Resend)

[Dmitry Timoshkov]

Nikolay Sivov <nsivov at codeweavers.com> wrote:

> On 2/1/22 22:16, Dmitry Timoshkov wrote:
> > Nikolay Sivov <nsivov at codeweavers.com> wrote:
> >
> >>> It looks like assigning a reviewer for a patch doesn't work very well.
> >>> Can the situation be improved somehow? Is there any responsibility of
> >>> a reviewer for ignoring the assigment?
> >>>
> >> Since this is exactly the same as the original patches, same concerns
> >> expressed initially apply for it as well.
> > I didn't see any real concern. Could you please try to be more specific?
> 
> Everything that I mentioned before - using windows-specific font name 
> both for tests and code changes for no good reason,
> especially since user won't have it installed; 

That's not a problem at all: font with name Segoe UI Symbol could be added
to Wine just like Tahoma, Wingdings, Webdings and others. I've already created
such a font with just one glyph - 0x25d4.

> char ranges picked rather 
> arbitrarily with no explanation.

I have provided an explanation together with an application that generates
complete dwrite fallback ranges.

If that helps I'm fine with just adding U+25A0..U+25FF (Geometric Shapes)
fallback range that fully fits into Segoe UI Symbol, and is a very small
subset covered by that font:
https://en.wikipedia.org/wiki/Geometric_Shapes_(Unicode)
http://www.unicode-symbol.com/block/Geometric_Shapes.html

-- 
Dmitry.