[RFC PATCH v4 3/5] server: Attempt to complete I/O request immediately in recv_socket.

[Zebediah Figura]

On 2/3/22 10:26, Jinoh Kang wrote:
>>> diff --git a/server/protocol.def b/server/protocol.def
>>> index d79eca074a0..137e6c5a220 100644
>>> --- a/server/protocol.def
>>> +++ b/server/protocol.def
>>> @@ -1456,6 +1456,7 @@ enum server_fd_type
>>>    @REPLY
>>>        obj_handle_t wait;          /* handle to wait on for blocking recv */
>>>        unsigned int options;       /* device open options */
>>> +    int          may_restart;   /* May restart async? */
>>>    @END
>>>      
>>
>> "may_restart" takes me a minute to realize what it actually means. Could we just return the (non)blocking flag directly instead?
> 
> So we do "force_async || !nonblocking" at the client side, I guess?
> 

Yeah.

I guess another alternative is just to call this field "blocking". That 
might apply to the server-side "pending" local variable also; maybe that 
would address one of my comments on 5/5.