[PATCH 2/2] include: Add debug utilities for Media Foundation modules
Nikolay Sivov
nsivov at codeweavers.com
Mon Feb 7 10:01:08 CST 2022
On 2/7/22 18:57, Alexandre Julliard wrote:
> Nikolay Sivov <nsivov at codeweavers.com> writes:
>
>> On 2/7/22 17:49, Andrew Eikum wrote:
>>> @@ -853,7 +854,7 @@ static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DW
>>> unsigned int count;
>>> GUID *guids;
>>> - TRACE("%p, %lu, %p, %#lx.\n", iface, id, media_type, flags);
>>> + TRACE("%p, %lu, %p %s, %#lx.\n", iface, id, media_type, wine_dbgstr_mfmediatype(media_type), flags);
>> I haven't tried it, but I agree that it looks useful. One minor thing
>> is that on null argument you get two nulls printed, but that's not a
>> big deal.
> It may be useful, but it looks awfully specific for a global header. If
> we want that sort of thing it would have to be made more generally
> useful.
>
We can certainly have a copy of such header in every module that needs
it, so we can easily sync them. It might be possible to share via some
custom export, but I think it's worse than a copy, especially because
many modules are usable on Windows, which helps testing a lot.
More information about the wine-devel
mailing list