[PATCH 4/4] ddraw/tests: Account for random WARP behavior in test_texturemapblend.
Stefan Dösinger
stefandoesinger at gmail.com
Wed Feb 9 02:06:55 CST 2022
> Am 08.02.2022 um 16:41 schrieb Henri Verbeet <hverbeet at gmail.com>:
>
> On Sun, 6 Feb 2022 at 18:15, Stefan Dösinger <stefan at codeweavers.com> wrote:
>> + /* SPECULARENABLE shouldn't matter in this test, but WARP begs to
>> + * differ. In the event that color keying is randomly on(see comments
>> + * in test_ck_default for reference), WARP will randomly discard
>> + * geometry based on something, even though texture anddiffuse color
>> + * alpha components are non - zero.Setting SPECULARENABLE to FALSE
>> + * prevents this in some cases - presumably WARP multiplies the
>> + * specular color "alpha" channel into the final result and then
>> + * alpha tests the result.Since the specular property normally does
>> + * not have an alpha component the actual specular color we set in
>> + * the vertex data above does not matter. */
>> + emit_set_rs(&ptr, D3DRENDERSTATE_SPECULARENABLE, FALSE);
>> +
> I'm not quite sure what happened above, but that comment is full of
> white-space errors.
Ah, I typed that thing in notepad, copypasted it into Visual Studio later. Either my butterfly keyboard is going bad again or something decides to be smart about whitespace when copypasting...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220209/61ad8837/attachment.sig>
More information about the wine-devel
mailing list