[PATCH] ws2_32: Output WARN on operation failure.

Paul Gofman pgofman at codeweavers.com
Wed Feb 9 10:33:26 CST 2022


On 2/9/22 19:30, Zebediah Figura wrote:
> On 2/9/22 04:13, Paul Gofman wrote:
>> Signed-off-by: Paul Gofman <pgofman at codeweavers.com>
>> ---
>>       The old winsock implementation was printing warnings for any 
>> error status from socket
>>       operation. That was handy for debugging. Without that pretty 
>> much any problem analysis
>>       involving tracing network operations starts from adding such logs.
>>
>
> I don't object to this in general, but can we at least avoid warning 
> on EWOULDBLOCK / STATUS_DEVICE_NOT_READY where relevant?
>
Maybe we just TRACE instead of WARN? Just not sure any heuristics here 
is better than a plain info output, both for analysis and for extra 'if' 
in the code.




More information about the wine-devel mailing list