[PATCH 02/10] ncrypt: Test key import of an rsa key.

[Zebediah Figura]

On 2/14/22 03:56, Hans Leidekker wrote:>>   SECURITY_STATUS WINAPI 
NCryptCreatePersistedKey(NCRYPT_PROV_HANDLE, NCRYPT_KEY_HANDLE *, const 
WCHAR *, const WCHAR *, DWORD, DWORD);
>>   SECURITY_STATUS WINAPI NCryptDecrypt(NCRYPT_KEY_HANDLE, BYTE *, DWORD, void *, BYTE *, DWORD, DWORD *, DWORD);
>>   SECURITY_STATUS WINAPI NCryptEncrypt(NCRYPT_KEY_HANDLE, BYTE *, DWORD, void *, BYTE *, DWORD, DWORD *, DWORD);
>>   SECURITY_STATUS WINAPI NCryptFinalizeKey(NCRYPT_KEY_HANDLE, DWORD);
>>   SECURITY_STATUS WINAPI NCryptFreeObject(NCRYPT_HANDLE);
>>   SECURITY_STATUS WINAPI NCryptOpenKey(NCRYPT_PROV_HANDLE, NCRYPT_KEY_HANDLE *, const WCHAR *, DWORD, DWORD);
>> +SECURITY_STATUS WINAPI NCryptImportKey(NCRYPT_PROV_HANDLE provider, NCRYPT_KEY_HANDLE decrypt_key,
>> +                                       const WCHAR *type, NCryptBufferDesc *params, NCRYPT_KEY_HANDLE *key,
>> +                                       PBYTE data, DWORD datasize, DWORD flags);
>>   SECURITY_STATUS WINAPI NCryptOpenStorageProvider(NCRYPT_PROV_HANDLE *, const WCHAR *, DWORD);
> 
> Parameter names are not very useful here. Please keep these sorted.
> 
> 
> 

I suppose it's a matter of taste, but for what it's worth, I tend to 
find them nice when calling functions, i.e. I can easily look up the 
signature in the header.