[PATCH v2 4/5] winepulse.drv: Fetch actual application name, if possible.

Andrew Eikum aeikum at codeweavers.com
Tue Feb 15 13:06:25 CST 2022


On Tue, Feb 15, 2022 at 08:51:01PM +0200, Gabriel Ivăncescu wrote:
> On 15/02/2022 17:20, Andrew Eikum wrote:
> > On Thu, Feb 10, 2022 at 06:07:47PM +0200, Gabriel Ivăncescu wrote:
> > > @@ -395,7 +493,7 @@ int WINAPI AUDDRV_GetPriority(void)
> > >       struct test_connect_params params;
> > >       char *name;
> > > -    params.name   = name = get_application_name();
> > > +    params.name   = name = get_application_name(FALSE);
> > 
> > Do you know why we want FALSE here?
> > 
> 
> I didn't want to change existing behavior (since it's only used for
> querying). The comment says some broken apps call it during DllMain. Are
> those APIs (when querying app name) safe to call from it?

Oh, that makes sense. It's fine like this then, thanks.

Andrew



More information about the wine-devel mailing list