[PATCH v2 1/2] iphlpapi: Fix ULONG comparisons, most notably for IPv4 addresses.

Huw Davies huw at codeweavers.com
Wed Feb 16 01:31:00 CST 2022


On Tue, Feb 15, 2022 at 03:31:10PM +0100, Francois Gouget wrote:
> +static int DWORD_cmp( DWORD a, DWORD b )
> +{
> +    return a < b ? -1 : a > b ? 1 : 0; /* a substraction would overflow */

The patch looks fine, but to save yourself having to send in a spelling
fix later on, let's get it right from the start ;-)  This is also
applies to the inetmib series.

Huw.



More information about the wine-devel mailing list