[PATCH v2] quartz: Always allocate the entire VIDEOINFO structure.
Zebediah Figura
zfigura at codeweavers.com
Thu Feb 17 12:33:09 CST 2022
From: Eric Pouech <eric.pouech at gmail.com>
Signed-off-by: Eric Pouech <eric.pouech at gmail.com>
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
---
v2: Fix the subject; add an explanatory comment.
dlls/quartz/avidec.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/dlls/quartz/avidec.c b/dlls/quartz/avidec.c
index f8660890273..f473c829cba 100644
--- a/dlls/quartz/avidec.c
+++ b/dlls/quartz/avidec.c
@@ -342,9 +342,12 @@ static HRESULT avi_decompressor_source_get_media_type(struct strmbase_pin *iface
if (index < ARRAY_SIZE(formats))
{
- if (!(format = CoTaskMemAlloc(offsetof(VIDEOINFO, dwBitMasks[3]))))
+ /* In theory we could allocate less than this, but gcc generates
+ * -Warray-bounds warnings if we access the structure through a
+ * VIDEOINFO pointer, even if we only access valid fields. */
+ if (!(format = CoTaskMemAlloc(sizeof(*format))))
return E_OUTOFMEMORY;
- memset(format, 0, offsetof(VIDEOINFO, dwBitMasks[3]));
+ memset(format, 0, sizeof(*format));
format->rcSource = sink_format->rcSource;
format->rcTarget = sink_format->rcTarget;
--
2.34.1
More information about the wine-devel
mailing list