[PATCH 1/2] Add test for RedrawWindow with both validate and internal paint flags.
Saulius Krasuckas
saulius2 at ar-fi.lt
Sat Feb 19 15:50:45 CST 2022
On 2022-02-19 22:59, Eric Pouech wrote:
> Le 19/02/2022 à 20:38, Roman Pišl a écrit :
>> unfortunately this code mixes tabs and spaces in a very ugly way - it
>> indents by 4 but tab size is expected to be 8. I'll fix it in the next
>> version after review..
>>
>> Or would a patch that removes completely all tabs from the file be
>> acceptable?
> generally, for space/tab choice, the rule is to keep the options taken
> for the file to edit...
>
> hard to tell on this file what's the choice made <g>
>
> in this case, I'd say go for spaces only.
IIRC, fifteen years ago specifically that was the de-facto rule. I
guess it's still valid:
https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice#Some_notes_about_style:~:text=Tabs%20are%20not%20forbidden%20but%20discouraged.
> * Tabs are not forbidden but discouraged. A tab is defined as 8
> characters and the usual amount of indentation is 4 characters.
S.
More information about the wine-devel
mailing list