[PATCH vkd3d 1/6] vkd3d-shader/hlsl: Properly free parse_variable_def memory in declare_vars().

Matteo Bruni matteo.mystral at gmail.com
Thu Feb 24 08:07:28 CST 2022


On Wed, Feb 16, 2022 at 9:47 AM Giovanni Mascellani
<gmascellani at codeweavers.com> wrote:
>
> Signed-off-by: Giovanni Mascellani <gmascellani at codeweavers.com>
> ---
> I still think that a nearly 200 lines long function with relatively
> complicated execution flow and such a messy memory management is a bomb
> ready to go off, and that this patch proves my point.

Splitting off the function or otherwise simplifying the code are
options on the table, sure. It's not that clear to me how to do that
in a sensible manner though (not that I tried very hard to think about
it).



More information about the wine-devel mailing list