[PATCH v4 1/4] wdscore: Implement CurrentIP.

Mohamad Al-Jaf mohamadaljaf at gmail.com
Fri Jan 28 22:35:39 CST 2022


Hi Giovanni,

I see, thanks for the clarification.

Yes, the patch solves the bug. Well, for the tests removing WINAPI seems to
change the pointer a bit, but it's still within the range so it doesn't
seem to affect it.

I haven't tried it with __ASM_GLOBAL_FUNC, but it seems to work fine as is.
Along with the stubs in this patchset, wdscore functions similarly to the
native version, at least for the media creation tool.

Still, I'm just wondering if using __ASM_STDCALL_FUNC isn't accurate? In
the CallCbsCore headers, CurrentIP is defined without WINAPI.[1]

I don't know what to do now. If it's okay to use WINAPI, should I resubmit
the older version of this patch?

[1] https://github.com/seven-mile/CallCbsCore/blob/master/StackManager.h
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220128/e4303faf/attachment.htm>


More information about the wine-devel mailing list