<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 6.00.2715.400" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT face=Arial size=2>Hi,</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>I am having a problem with the way toolbar.c was
modified between revisions 1.107 & 1.108. My application (Signlab) pops
flyout toolbars that stay around until they lose focus. The parent toolbar
receives a 'TBN_DROPDOWN' message when someone clicks on one of its flyout
buttons (button style: TBSTYLE_DROPDOWN). It creates a flyout at that
point.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>With revision 1.108 of toolbar.c in Wine the parent
toolbar also receives an WN_COMMAND after TBN_DROPDOWN message which causes
Wine (rightly so) to send an WM_SETFOCUS (and WM_ACTIVATE). That causes the
parent to regain focus and kills the flyout. The line that sends
the WN_COMMAND is in toolbar.c at line 4540 (TOOLBAR_LButtonUp()
function):<BR></FONT></DIV>
<DIV><FONT face=Arial size=2>
SendMessageA (infoPtr->hwndNotify,
WM_COMMAND,<BR>
MAKEWPARAM(infoPtr->buttons[nHit].idCommand, 0),
(LPARAM)hwnd);<BR></FONT></DIV>
<DIV><FONT face=Arial size=2>In revision 1.107 it used to be:</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>if (bSendMessage)<BR>
SendMessageA (infoPtr->hwndNotify, WM_COMMAND,<BR>
MAKEWPARAM(btnPtr->idCommand, 0), (LPARAM)hwnd);</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>And that worked fine because it would never send
WM_COMMAND for a flyout button. Note that WinXP (that's where I
tested) doesn't send WM_COMMAND after TBN_DROPDOWN has been handled. I
would like to suggest revert that line back to 1.106 because it is the correct
way.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>If other apps are were having problems with 1.106
(Duane was mentioning Acrobat Reader - I will test that..) I suggest that
the problem might be elsewhere.</FONT></DIV>
<DIV><FONT face=Arial size=2></FONT> </DIV>
<DIV><FONT face=Arial size=2>Should I supply a patch?<BR></FONT></DIV>
<DIV><FONT face=Arial size=2>Cheers,</FONT></DIV>
<DIV><FONT face=Arial size=2>Dusan</FONT></DIV>
<DIV><FONT face=Arial size=2> </DIV>
<DIV><BR></DIV></FONT></BODY></HTML>