<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2653.12">
<TITLE>RE: FW: Edit Paste operation does not behave same as MS Windows</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>This means it is sufficient to return FALSE in EDIT_MakeFit if the honor limit is not set and size exceeds the buffer limit? </FONT></P>
<P><FONT SIZE=2>static BOOL EDIT_MakeFit(EDITSTATE *es, UINT size, BOOL honor_limit)</FONT>
<BR><FONT SIZE=2>{</FONT>
<BR> <FONT SIZE=2>HLOCAL hNew32W;</FONT>
</P>
<P> <FONT SIZE=2>if ((!honor_limit) && (es->buffer_limit > 0) && (size > es->buffer_limit)) {</FONT>
<BR> <FONT SIZE=2>EDIT_NOTIFY_PARENT(es, EN_MAXTEXT, "EN_MAXTEXT");</FONT>
<BR> <FONT SIZE=2>return FALSE;</FONT>
<BR> <FONT SIZE=2>}</FONT>
<BR><FONT SIZE=2>... </FONT>
<BR><FONT SIZE=2>}</FONT>
</P>
<P><FONT SIZE=2>I will verify with this change and if works in all condition, will submit the patch.</FONT>
<BR><FONT SIZE=2>Thanks for your help,</FONT>
<BR><FONT SIZE=2>Krishna</FONT>
</P>
<BR>
<P><FONT SIZE=2>-----Original Message-----</FONT>
<BR><FONT SIZE=2>From: Alexandre Julliard [<A HREF="mailto:julliard@winehq.org">mailto:julliard@winehq.org</A>] </FONT>
<BR><FONT SIZE=2>Sent: Thursday, May 27, 2004 5:12 PM</FONT>
<BR><FONT SIZE=2>To: Krishna Murthy</FONT>
<BR><FONT SIZE=2>Cc: wine-devel@winehq.org</FONT>
<BR><FONT SIZE=2>Subject: Re: FW: Edit Paste operation does not behave same as MS Windows</FONT>
</P>
<P><FONT SIZE=2>Krishna Murthy <Krishna.Murthy@guptaworldwide.com> writes:</FONT>
</P>
<P><FONT SIZE=2>> Actually the logic truncates the data which exceeded the buffer. If </FONT>
<BR><FONT SIZE=2>> the honor limit is set and the size exceeded, the EDIT_MakeFit will return TRUE.</FONT>
<BR><FONT SIZE=2>> The following code after the EDIT_MakeFit will try to take limit to </FONT>
<BR><FONT SIZE=2>> the buffer size.</FONT>
<BR><FONT SIZE=2>></FONT>
<BR><FONT SIZE=2>> + /* Only replace or insert that many characters that can fit into the</FONT>
<BR><FONT SIZE=2>> + edit control. Do this only if honor_limit is TRUE */</FONT>
<BR><FONT SIZE=2>> + if(honor_limit && strl > es->buffer_limit)</FONT>
<BR><FONT SIZE=2>> + strl = es->buffer_limit - (tl - (e-s));</FONT>
</P>
<P><FONT SIZE=2>That only takes into account the limit, not the current buffer size. It's very possible that you need to grow the buffer even when the limit is not exceeded. Also you only check the length of the inserted string against the limit, you should check the total resulting length instead.</FONT></P>
<P><FONT SIZE=2>--</FONT>
<BR><FONT SIZE=2>Alexandre Julliard</FONT>
<BR><FONT SIZE=2>julliard@winehq.org</FONT>
</P>
</BODY>
</HTML>