<P>returning a pointer to something on the stack is something I call an error</P>
<P>(how do you ensure that the buffer will not get overwritten by another function call ?)</P>
<P>A+<BR><BR></P>
<BLOCKQUOTE style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #ff0000 2px solid">> Message du 02/06/05 15:25<BR>> De : "Dimi Paun" <DIMI@LATTICA.COM><BR>> A : pouech-eric@wanadoo.fr, wine-devel@winehq.org<BR>> Copie à : <BR>> Objet : Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings<BR>> <BR>> From: "Pouech Eric DMI AEI CAEN" <POUECH-ERIC@WANADOO.FR><BR>> > looking at the patch, I saw something in the code that made me sick:<BR>> > char *audioAutoDetect(void)<BR>> > {<BR>> > [snip]<BR>> > char *driversFound[10];<BR>> > [snip]<BR>> > return driversFound[0];<BR>> > [snip]<BR>> > }<BR>> > <BR>> > can someone fix that broken code ?<BR>> <BR>> Yeah, it's not pretty, but just by looking at this snippet there is no<BR>> obvious error in the above AFAICT.<BR></BLOCKQUOTE>